Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend remote write options and add read read option. #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b13n1u
Copy link

@b13n1u b13n1u commented Apr 22, 2018

This PR adds additional config for remote read and writes.

@epcim
Copy link
Member

epcim commented Jun 4, 2018

Just run make test on your local, there is an typo:

$ make test | tail
/home/travis/build/salt-formulas/salt-formula-prometheus/tests/build/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/urllib3/util/ssl_.py:339: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  SNIMissingWarning
/home/travis/build/salt-formulas/salt-formula-prometheus/tests/build/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/urllib3/util/ssl_.py:137: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecurePlatformWarning
/home/travis/build/salt-formulas/salt-formula-prometheus/tests/build/virtualenv/local/lib/python2.7/site-packages/pip/_vendor/urllib3/util/ssl_.py:137: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
  InsecurePlatformWarning
[CRITICAL] Rendering SLS 'base:prometheus.server' failed: found unexpected ':'; line 20
---
[...]
  file.managed:
    - name: /srv/volumes/prometheus/server/prometheus.yml
    - source: salt://prometheus/files/server/prometheus.yml
    - template: jinja
    - defaults:
        server: {u'alertmanager': {u'notification_queue_capacity': 10000}, 'target': {u'etcd': {u'endpoint': {u'scheme': u'https', u'ssl_dir': u'/opt/prometheus/config', u'cert_name': u'prometheus-server.crt', u'key_name': u'prometheus-server.key', u'member': [{u'host': u'${_param:cluster_node01_address}', u'port': 
...
...

@fpytloun
Copy link
Member

fpytloun commented Jun 4, 2018

You could also add an example into readme

@b13n1u
Copy link
Author

b13n1u commented Jun 14, 2018

Thanks for review. I'll fix the typo and add some readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants